Merge pull request #41 from hmrc/APIS-2888

APIS-2888
hmrc · Nov 23, 2017 · 564e924 · 564e924
2 parents 847c2b6 + 436c3a9
commit 564e924
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/app/uk/gov/hmrc/apisubscriptionfields/controller/FieldsDefinitionController.scala b/app/uk/gov/hmrc/apisubscriptionfields/controller/FieldsDefinitionController.scala
@@ -48,7 +48,7 @@ class FieldsDefinitionController @Inject() (service: FieldsDefinitionService) ex
   }
 
   def getAllFieldsDefinitions: Action[AnyContent] = Action.async { implicit request =>
-    Logger.debug(s"[getAllFieldsDefinitions]")
+    Logger.debug("[getAllFieldsDefinitions]")
     service.getAll map (defs => Ok(Json.toJson(defs))) recover recovery
   }
 

diff --git a/build.sbt b/build.sbt
@@ -106,7 +106,7 @@ lazy val acceptanceTestSettings =
     )
 
 lazy val scoverageSettings: Seq[Setting[_]] = Seq(
-  coverageExcludedPackages := "<empty>;Reverse.*;model.*;.*config.*;.*(AuthService|BuildInfo|Routes).*",
+  coverageExcludedPackages := "<empty>;Reverse.*;.*model.*;.*config.*;.*(AuthService|BuildInfo|Routes).*;.*.application;.*.definition",
   coverageMinimum := 93,
   coverageFailOnMinimum := true,
   coverageHighlighting := true,

diff --git a/...unit/uk/gov/hmrc/apisubscriptionfields/controller/FieldsDefinitionControllerPutSpec.scala b/...unit/uk/gov/hmrc/apisubscriptionfields/controller/FieldsDefinitionControllerPutSpec.scala
@@ -58,6 +58,13 @@ class FieldsDefinitionControllerPutSpec extends UnitSpec
         status(result) shouldBe OK
       }
     }
+
+    "error when request is invalid" in {
+      val json = Json.parse("{}")
+      testSubmitResult(mkRequest(json)) { result =>
+        status(result) shouldBe UNPROCESSABLE_ENTITY
+      }
+    }
   }
 
   private def testSubmitResult(request: Request[JsValue])(test: Future[Result] => Unit) {