HMA-5257 Reduced minHeight for InformationMessageCardView buttons fro…

…m 60dp to 0dp so they do not look so big in the context of the InformationMessageCardView. (#72)
hmrc · Feb 3, 2022 · 2e659ff · 2e659ff
1 parent cba9801
commit 2e659ff
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,10 @@ Allowed headings:
 
 ## [Unreleased]
 
+### Changed
+
+* Updated `InformationMessageCardView` buttons so that the button `minHeight` is reset from the default 60dp to 0dp. This means that buttons now only occupy the vertical space that they need and no more.
+
 ## [3.21.0] - 2022-01-25
 
 ### Added

diff --git a/...s/src/main/java/uk/gov/hmrc/components/organism/information/InformationMessageCardView.kt b/...s/src/main/java/uk/gov/hmrc/components/organism/information/InformationMessageCardView.kt
@@ -100,6 +100,7 @@ class InformationMessageCardView @JvmOverloads constructor(
 
         binding.headlineButtonsContainer.visibility = if (buttons.isNotEmpty()) View.VISIBLE else View.GONE
         buttons.forEach {
+            it.minHeight = 0
             it.setMargins(spacing16, spacing8, spacing16, 0)
             it.backgroundTintList = ContextCompat.getColorStateList(context, R.color.hmrc_white)
             it.gravity = Gravity.CENTER

diff --git a/.../uk.gov.hmrc.components.sample.organisms.InformationMessageCardViewTest_day.png b/.../uk.gov.hmrc.components.sample.organisms.InformationMessageCardViewTest_day.png
diff --git a/...k.gov.hmrc.components.sample.organisms.InformationMessageCardViewTest_night.png b/...k.gov.hmrc.components.sample.organisms.InformationMessageCardViewTest_night.png
diff --git a/....gov.hmrc.components.sample.organisms.InformationMessageCardViewTest_scaled.png b/....gov.hmrc.components.sample.organisms.InformationMessageCardViewTest_scaled.png