Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 956 email icon hyperlinks #383

Merged
merged 6 commits into from
May 7, 2024
Merged

Conversation

chandans1316
Copy link
Collaborator

Issue

Fixes: https://merative.atlassian.net/browse/MERATIVE-956

Description

On the "Headshot" block, when an email hyperlink is used in content, it shows up as a link icon.

Test URLs

Test Description

All email hyperlink ([email protected]) should show the attached mail icon instead.

Copy link

aem-code-sync bot commented Apr 29, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 29, 2024

Page Scores Audits Google
/drafts/Keith/common-spirit-health PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@joehanchoi joehanchoi self-requested a review April 29, 2024 18:58
Copy link
Collaborator

@joehanchoi joehanchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon is oversized on Safari browser windows

@aem-code-sync aem-code-sync bot temporarily deployed to issue-956-email-icon-hyperlinks April 30, 2024 07:00 Inactive
@joehanchoi joehanchoi self-requested a review April 30, 2024 13:21
Copy link
Collaborator

@joehanchoi joehanchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved Safari issue

@keith-kaplan keith-kaplan self-requested a review May 1, 2024 17:29
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The email icon is looking good. There needs to be a change to the border top line to ensure spans the fill width of the div. Right now it does not happen.

Design System
image

Webpage
image

This is the figma link - https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=12174%3A53663&mode=dev

@aem-code-sync aem-code-sync bot temporarily deployed to issue-956-email-icon-hyperlinks May 3, 2024 12:56 Inactive
@joehanchoi joehanchoi requested a review from keith-kaplan May 3, 2024 16:33
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raj-bluetext did you test this out on mobile/tablet? I'm seeing the one of the person's title get cut off and not wrap to an new line on the container.

Screenshot_20240506-142921

Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and confirmed works on mobile.

@keith-kaplan keith-kaplan merged commit 721ae4a into main May 7, 2024
2 checks passed
@keith-kaplan keith-kaplan deleted the issue-956-email-icon-hyperlinks branch May 7, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants