Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 914 #376

Merged
merged 19 commits into from
Apr 25, 2024
Merged

Issue 914 #376

merged 19 commits into from
Apr 25, 2024

Conversation

chandans1316
Copy link
Collaborator

@chandans1316 chandans1316 commented Apr 11, 2024

Issue

Fixes https://merative.atlassian.net/browse/MERATIVE-954
Fix : https://merative.atlassian.net/browse/MERATIVE-955

Description

https://merative.atlassian.net/browse/MERATIVE-955

When a content author adds the references block to a blog post, the Unordered lists/numbered lists and list items are not sized correctly. When the references block is removed, this issue gets fixed.

https://merative.atlassian.net/browse/MERATIVE-954

Tertriary button in leadspaces should be center aligned in the leadspace block. Currenlty it is aligned bottom.

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

Fixes https://merative.atlassian.net/browse/MERATIVE-954

Fix : https://merative.atlassian.net/browse/MERATIVE-955

Testing Instruction

Open each New URL and inspect the code changes to ensure they render according to the Design Specs in Figma

Note:
The changes are generic and affects all the support pages where "columns" and "leadspace" blocks are used.

Copy link

aem-code-sync bot commented Apr 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 11, 2024

Page Scores Audits Google
/block-library/templates/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/clinical-decision-support PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@keith-kaplan keith-kaplan self-requested a review April 23, 2024 15:01
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chandans1316 this needs to be updated so the Sources block is aligned to our design system. May you please work on this again.

@keith-kaplan
Copy link
Collaborator

keith-kaplan commented Apr 23, 2024

Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chandans1316. This looks better. Going to approve and merge.

@keith-kaplan keith-kaplan merged commit 2bd344a into main Apr 25, 2024
2 checks passed
@keith-kaplan keith-kaplan deleted the Issue-914 branch April 25, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants