Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duplicate-entries): removed duplicate entries #345

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

sahmad-merative
Copy link

Issue

Fixes MERATIVE-897

Description

We're seeing duplicate topic names within the Blog filtering page (/blog).
This is happening because Content Authors are not using consistent sentence cases for Topics that they're adding to Sharepoint. This is largely due to the nature of Franklin where the tagging/taxonomy is associated by the string name instead of a UID.

Changed
Adjusted the script for comparing the topic string/value and standardize the value to sentence case so that we can consistent filtering.

Design Specs N/A

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

  • Figma Link - N/A

Test URLs

Testing Instruction

If applicable, please describe the tests that you ran to verify your changes. Provide instructions and link to the hlx deploy preview so that QA and the design team can provide proper testing.

image

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

@sharathmrft sharathmrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahmad-merative First letter should be in Caps
image
@proeung @sachinmesh

@sahmad-merative
Copy link
Author

@sahmad-merative First letter should be in Caps image @proeung @sachinmesh

@proeung I believe the best approach to address this issue is to handle it at the content level. In my perspective, implementing font transformations through code may not be advisable, as it could inadvertently convert words that should remain in all uppercase to lowercase.

For instance, consider the text "HEOR" (as depicted in the screenshot below), which, when subjected to code-driven font transformation, might unintentionally become "Heor".

Similarly, if there are names or acronyms like "SPM," they could inadvertently be converted to all lowercase as well.
Screenshot 2023-09-28 at 6 16 30 PM

CC: @sharathmrft @sachinmesh @keith-kaplan

@proeung proeung self-assigned this Oct 2, 2023
@proeung
Copy link

proeung commented Oct 2, 2023

Adding myself as the assignee to this PR so that I can pick up this work since Saad is no longer on the project.

Copy link

@proeung proeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I don't have any code suggestions.

@keith-kaplan Can you take a look at deploy preview (https://885-duplicate-entries--merative2--sahmad-merative.hlx.page/blog) and let us know if the filter results are correct for the duplicate topics that you've noticed?

@proeung proeung added Needs Re-review This PR requires a re-review from QA and Designers and removed 🛠️ fix needed labels Oct 3, 2023
@proeung proeung dismissed sharathmrft’s stale review October 3, 2023 15:19

No longer on the team

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 3, 2023

Page Scores Audits Google
/blog PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sachinmesh sachinmesh requested a review from sharathmrft October 5, 2023 05:59
@keith-kaplan
Copy link
Collaborator

This looks good. @nimithshetty17 are you able to approve this?

@keith-kaplan keith-kaplan self-requested a review October 5, 2023 14:55
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I've checked the topic list.

@keith-kaplan keith-kaplan merged commit 63b6872 into hlxsites:main Oct 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Re-review This PR requires a re-review from QA and Designers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants