-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(duplicate-entries): removed duplicate entries #345
fix(duplicate-entries): removed duplicate entries #345
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahmad-merative First letter should be in Caps
@proeung @sachinmesh
@proeung I believe the best approach to address this issue is to handle it at the content level. In my perspective, implementing font transformations through code may not be advisable, as it could inadvertently convert words that should remain in all uppercase to lowercase. For instance, consider the text "HEOR" (as depicted in the screenshot below), which, when subjected to code-driven font transformation, might unintentionally become "Heor". Similarly, if there are names or acronyms like "SPM," they could inadvertently be converted to all lowercase as well. |
Adding myself as the assignee to this PR so that I can pick up this work since Saad is no longer on the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! I don't have any code suggestions.
@keith-kaplan Can you take a look at deploy preview (https://885-duplicate-entries--merative2--sahmad-merative.hlx.page/blog) and let us know if the filter results are correct for the duplicate topics that you've noticed?
|
This looks good. @nimithshetty17 are you able to approve this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and I've checked the topic list.
Issue
Fixes MERATIVE-897
Description
We're seeing duplicate topic names within the Blog filtering page (
/blog
).This is happening because Content Authors are not using consistent sentence cases for Topics that they're adding to Sharepoint. This is largely due to the nature of Franklin where the tagging/taxonomy is associated by the string name instead of a UID.
Changed
Adjusted the script for comparing the topic string/value and standardize the value to sentence case so that we can consistent filtering.
Design Specs N/A
Test URLs
main
): https://main--merative2--hlxsites.hlx.page/blogTesting Instruction