generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main menu new layout #267
Open
chandans1316
wants to merge
508
commits into
hlxsites:main
Choose a base branch
from
hlxsites:main-menu-new-layout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Main menu new layout #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added basic fonts * linting * anthonys suggested fixes --------- Co-authored-by: Charity Helms <[email protected]>
* needed 1200px padding * cleanup of who we serve type pages * linting --------- Co-authored-by: Charity Helms <[email protected]>
Co-authored-by: Charity Helms <[email protected]>
- allow `mailto` in links - add `headshots` block - remove `no-link-icon` support
* fonts and spacing fixes * more font fixes * linting --------- Co-authored-by: Charity Helms <[email protected]>
* Update styles.css Switch the dark purple to primary purple and transform white text in the section * update clip-path for quarter images
Marketo form columns
* add support for sections * adding section dashes
* Added manual links to Teaser List * updated to include external links * fixing some weird word link artifacts
* Fix accordion borders * Remove duoblication
- library config improvements
* first round of draft edits * Start to cleanup * linting * linting --------- Co-authored-by: Charity Helms <[email protected]> Co-authored-by: Anthony Rumsey <[email protected]>
* first round of draft edits * Start to cleanup * arrow hover color and underline fix * leadership page spacing
* A clip path for left and right quarter circles #169 - left and right clip paths for quarter circle - force leadspace image sizes - use top half of image when using `half-circle` - cleanup quarter-circle sizes in columns block * Link button icons are too large #171 - reduce link button icons to `20px`
* Fix to allow dev in localhost * Added scroll style to desktop * Making default PDF viewer IN_LINE * Switching to query-index instead of document-index * Edge case fix * updating helix-query.yaml to remove documents * adding other metadata fields to capture in index * Updating category to include blogs
* first round of draft edits * Start to cleanup * linting * linting * delete extra clip * arrow hover color and underline fix * leadership page spacing * linting * put transparent back * span.icon spacing back to 07 * A clip path for left and right quarter circles #169 - left and right clip paths for quarter circle * A clip path for left and right quarter circles #169 - left and right clip paths for quarter circle * A clip path for left and right quarter circles #169 - left and right clip paths for quarter circle * A clip path for left and right quarter circles #169 - force leadspace image sizes - use top half of image when using `half-circle` * remove space from images in p tags * A clip path for left and right quarter circles #169 - cleanup quarter-circle sizes in columns block * Link button icons are too large #171 - reduce link button icons to `20px` * Link button icons are too large #171 - reduce link button icons to `20px` * leadspace formula established for margins and applied * Link button icons are too large #171 - reduce link button icons to `20px` * requested changes * linting * account for no-clip in news image * linting fixes * spacing bugs found * linting * new lines and some bracket spacing * remove leadspace + columns confusion * change the media query version now * more linting * more linting --------- Co-authored-by: Charity Helms <[email protected]> Co-authored-by: Anthony Rumsey <[email protected]>
* Navattic hamburger icons. * Leadspace anchor link updation. * Leadspace scroll font fix. --------- Co-authored-by: keith-kaplan <[email protected]>
* Navattic hamburger icons. * Stat with illustration padding issue. * No padding at the top option. * Stats width issue.
* Navattic hamburger icons. * PDF viewer issue. * PDF viewer padding issue.
* This script now includes a global array selectedOrder to track the order of selected tags. The toggleTag function has been modified to update this array when a tag is selected or deselected. The displaySelected function uses this array to display the tags in the order they were selected, ensuring that the selection order is consistent regardless of their DOM order. The toggleTag function now considers both the title and the category of a tag when toggling its selection. The displaySelected function uses the updated selectedOrder array, which contains objects with title and category properties, to display the selected tags. The clear button event listener in the init function now resets the selectedOrder array when clearing the selection. This should ensure that tags with duplicate names in different categories are handled correctly, and their selection order is maintained as expected. Instead of using querySelector with :contains, it iterates over all categories and checks their h2 text content to find the matching category. Once the correct category is found, it searches for the tag with the matching title within that category. This approach should resolve the error and correctly handle the selection and display of tags, even when they have duplicate names in different categories. Each tag is identified by both its title and its category, allowing for proper handling of duplicate tag names in different categories. The selectedOrder array now stores objects with title and category properties. The displaySelected function has been updated to use this additional information when displaying selected tags. This approach should resolve the issue with duplicate tag names and ensure that tags are correctly identified and displayed based on both their title and category. * Fixed linting errors. * Removed "category" from buffer.
* Update styles.css Inserted addition px data * Update content-text-body.css Updated the code for fixes mentioned in issue 914 * Update short-cards.css Fixes related to Issue 914 * Update content-text-body.css content-text-body h5 - merged into one * Update breadcrumb.css Text replacement from "..." to "Home" * Updated content-text-body.css Spacing re-adjusted to 8 px --------- Co-authored-by: keith-kaplan <[email protected]> Co-authored-by: Ajeet Nellikeri <[email protected]>
* fix typo * forcing another commit * removing sitemap, just disallow
* issue-961-CPSfileupdated Update CPS to include 6Sense script * Removed '' marks on the 6sense scripts * Added 6sense scripts to connect src csp * Added 6sense script to img src and updated linkedIn script because it was also being blocked by csp --------- Co-authored-by: Ajeet Nellikeri <[email protected]> Co-authored-by: keith-kaplan <[email protected]>
* fix: move header height to styles, no longer dependent on lazy-loaded header block * chore: remove duplicative css * fix: apply main margin on styles load * fix: set all header styles
* 379-revert some of PR 378 CSS * add height back * moved fixed position * linting
* Update styles.css Inserted addition px data * Update content-text-body.css Updated the code for fixes mentioned in issue 914 * Update short-cards.css Fixes related to Issue 914 * Update content-text-body.css content-text-body h5 - merged into one * Update breadcrumb.css Text replacement from "..." to "Home" * Updated content-text-body.css Spacing re-adjusted to 8 px * 2 issues fixed MERATIVE-955 and MERATIVE-954 * Update styles.css * fix(Bullet Spacing and Text Size): Update reference.css and styles.css * Update references.css * Update references.css * Update references.css * Updated spacing as per requirements * Update styles.css * Updated style as per Footnotes --------- Co-authored-by: Ajeet-Nellikeri <[email protected]> Co-authored-by: keith-kaplan <[email protected]> Co-authored-by: Ajeet Nellikeri <[email protected]> Co-authored-by: Kanaksinh Rahevar <[email protected]> Co-authored-by: Kanaksinh <[email protected]>
* Added Drift popup code * Update marketo.js * Update marketo.js * Update marketo.js * Updated drift code for testing1 * Updated drift code for testing2 * Updated drift code for testing3 * Updated drift code for testing4 * removed unused code --------- Co-authored-by: Kanaksinh <[email protected]>
Co-authored-by: Kanaksinh <[email protected]>
* updated Email Icons for Email Hyperlinks in Headshot Block * Removed underline from mail icon * Updated Email Icon width * Line filled entire div * Fixed issue with element not wrapping properly. --------- Co-authored-by: Kanaksinh <[email protected]> Co-authored-by: keith-kaplan <[email protected]>
* Fixed Structure breaking issue * Update blog-left-nav.js --------- Co-authored-by: Kanaksinh <[email protected]>
* CTA wrap issue fixed * Fixed css lint issue --------- Co-authored-by: Kanaksinh <[email protected]>
* Testing drift code 1 * Added Drift ready code * Added location condition * Fixed lint issue * Removed Drift code --------- Co-authored-by: Kanaksinh <[email protected]> Co-authored-by: keith-kaplan <[email protected]>
Co-authored-by: Kanaksinh <[email protected]>
Co-authored-by: Kanaksinh <[email protected]> Co-authored-by: keith-kaplan <[email protected]>
* Added Drift Code Contact form2 * Cotact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code testing * Contact form drift code issue fixed * Updated sidebar style --------- Co-authored-by: Kanaksinh <[email protected]>
Co-authored-by: Kanaksinh <[email protected]> Co-authored-by: Joe Choi <[email protected]>
* Solutions header fix for css * Solutions header fix for css * Solutions header fix for css --------- Co-authored-by: Chandan Sharma <[email protected]>
Added new sitemap
removed broken sitemap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix #
Test URLs
Description