Feature small changes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hle-skillz
commented
Feb 21, 2020
Comment on lines
+26
to
+29
| image_url: "string", | ||
| deep_link: "string", | ||
| deep_link_text: "string", | ||
| }; |
There was a problem hiding this comment.
Hobbs: You should use real life data in your tests.
hle-skillz
commented
Feb 21, 2020
| import Label from 'Label'; | ||
| import Markdown from 'react-native-markdown-renderer'; | ||
| import PropTypes from 'prop-types'; | ||
| import styles from 'SkillzNewsMessageCellStyles'; | ||
| import DeepLinkUtils from 'DeepLinkUtils'; |
There was a problem hiding this comment.
Hobbs: This isn't in alphabetical order, fix it.
hle-skillz
commented
Feb 21, 2020
| @@ -20,7 +23,22 @@ export default class SkillzNewsMessageCell extends React.PureComponent { | |||
| newsArticle: PropTypes.object.isRequired, | |||
| } | |||
|
|
|||
| constructor(props: any) { | |||
There was a problem hiding this comment.
Hobbs: This should obviously be a stateless component, do you have any real need for state here, why are you using it?
|
Calvin: Hobbes, can I just fix these later? I have a team demo in an hour and need these changes to be in the build. |
hle-skillz
commented
Feb 22, 2020
Comment on lines
+30
to
+31
|
|
||
| fakemesageForError(): SkillzNewsMessage { |
There was a problem hiding this comment.
Hobbs: I would not have put this function here.
hle-skillz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this pull request?
How were the changes tested locally?
Are the following completed?
yarn test)Status of any added tests?
Any screenshots/gifs for visual changes?
Who is the first round reviewer?
Hobbs