Use stimulus controller for dependent checkboxes and add specs #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheWalkingLeek
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Mir sind beim Durchtesten noch zwei Dinge aufgefallen:
- Ich kann als normaler Nutzer soweit ich sehe nie auf den
TerminateSacMembershipWizardnavigieren. Im Dropdown wird ein can? für die Wizard Konstante aufgerufen aber der Wizard hat keine Ability => gibt immerfalsehttps://github.com/hitobito/hitobito_sac_cas/blob/master/app/helpers/dropdown/people/memberships.rb#L37 - Ich kann das "Daten aufbewahren" Checkmark einfach händisch wieder abwählen. So kann ein Zustand entstehen, bei dem der "Daten aufbewahern" unchecked und zB "Spenden" checked. Soll das so? Wenn nicht müsste man das wohl im UI locken und es bräuchte eine Backend Validierung
|
|
||
| - stimulus_ctrl = 'form-field-check-dependent' | ||
| %div{data: { controller: stimulus_ctrl }} | ||
| - if current_user.backoffice? and c.model.mitglied_termination_by_section_only? |
There was a problem hiding this comment.
Suggested change
| - if current_user.backoffice? and c.model.mitglied_termination_by_section_only? | |
| - if current_user.backoffice? && c.model.mitglied_termination_by_section_only? |
| expect(find("#wizards_memberships_terminate_sac_membership_wizard_summary_data_retention_consent")).not_to be_checked | ||
| end | ||
|
|
||
| it "check newsletter and sac spenden uncheck one, doesnt uncheck data_retention_consent" do |
There was a problem hiding this comment.
Suggested change
| it "check newsletter and sac spenden uncheck one, doesnt uncheck data_retention_consent" do | |
| it "do not uncheck data_retention_consent when unchecking newsletter or sac spenden" do |
| check "Ich möchte weiterhin über Spendenaktionen informiert werden." | ||
| expect(find("#wizards_memberships_terminate_sac_membership_wizard_summary_data_retention_consent")).to be_checked | ||
| uncheck "Newsletter beibehalten" | ||
| expect(find("#wizards_memberships_terminate_sac_membership_wizard_summary_data_retention_consent")).to be_checked |
There was a problem hiding this comment.
Suggested change
| expect(find("#wizards_memberships_terminate_sac_membership_wizard_summary_data_retention_consent")).to be_checked | |
| expect(find("#wizards_memberships_terminate_sac_membership_wizard_summary_data_retention_consent")).to be_checked | |
| uncheck "Ich möchte weiterhin über Spendenaktionen informiert werden." | |
| expect(find("#wizards_memberships_terminate_sac_membership_wizard_summary_data_retention_consent")).to be_checked |
Noch testen obs beim anderen Feld auch so ist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI run with core branch: https://github.com/hitobito/hitobito_sac_cas/actions/runs/10940693226