Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMPORT: Import 1_people umstellen auf CSV-Report und CSV-Source #862

Merged
merged 46 commits into from
Sep 4, 2024
Merged

IMPORT: Import 1_people umstellen auf CSV-Report und CSV-Source #862

merged 46 commits into from
Sep 4, 2024

Conversation

openscript
Copy link
Contributor

No description provided.

@openscript openscript linked an issue Aug 20, 2024 that may be closed by this pull request
PEOPLE: Import 1_people umstellen auf CSV-Report und CSV-Source #767
Closed
17 tasks
openscript and others added 22 commits August 21, 2024 07:16
@openscript
write report
a92ad3f
@openscript
add company handling
910538c
@openscript
adapt new source format
abc053d
@openscript
Merge branch 'master' into 767-people-import-1_people-umstellen-auf-c…
5557e61 
…sv-report-und-csv-source
@openscript
skip membership tests
0fa0021
@openscript
skip membership tests
f14567f
@openscript
skip membership tests
7868302
@openscript
import family number
7016c03
@rnestler @openscript
Pull translations from transifex
c79cd9f
@hunchr @openscript
Use update_attribute for data quality checker
b34791e 
The seeds were broken because 'hito42bito' is an invalid password and `update!` validates all attributes
@codez @openscript
Move invoice jobs to same namespaces as domain classes (#870)
72a3ae9 
* Move invoice jobs to same namespaces as domain classes

* Prototype create yearly invoices job, refs #803
@njaeggi @amaierhofer @openscript
Create abacus membership invoice via job (#745)
2c563b0 
* Create job and adjust generator domain class

* Refactorings from review, include more specs

---------

Co-authored-by: Andreas Maierhofer <[email protected]>
@kronn @openscript
Pull translations from transifex
d6bc7d3
@amaierhofer @openscript
Always render stammsektion option for membership invoice (#745)
e07bacf
@openscript
disable membership tests
668a5a3
@openscript
fix csv source spec
0192d63
@openscript
disable membership tests
fbbcd00
@openscript
Merge branch 'master' into 767-people-import-1_people-umstellen-auf-c…
fa4f2f8 
…sv-report-und-csv-source
@openscript
update people importer integration spec
eee0db1
@openscript
fix people importer spec
561d8c6
@openscript
exclude failing classes
658f187
@openscript
fix people importer spec
524fa9a
@openscript openscript marked this pull request as ready for review August 27, 2024 08:19
@openscript openscript changed the title 767 people import 1 people umstellen auf csv report und csv source IMPORT: Import 1_people umstellen auf CSV-Report und CSV-Source Aug 27, 2024
rnestler and others added 11 commits August 29, 2024 14:37
@rnestler @openscript
Document the pending self-inscription spec (#874)
47846bb
@amaierhofer @openscript
Minor sektion group and roles adjustments (#831)
eed41a3
@TheWalkingLeek @openscript
Add SAC Kurskader group (#877)
0aebb17
@hunchr @openscript
Fix rubocop_todo for specs
e4cd4fc
@hunchr @openscript
Add new Verbaende group to dachverband (#830)
9e12be0 
* Add groups

# Conflicts:
#	app/models/group/sac_cas.rb

* Add locales
@TheWalkingLeek @openscript
Pull translations from transifex
0c96513
@codez @openscript
Run github action only when pushing master branch, create pr to build…
4c1aa43 
… other branches (#883)
@hunchr @TheWalkingLeek @openscript
Create invoice only if no data quality errors exist (#879)
d0045bf 
* Add data quality alert

* Update invoice job

* Add specs

* Update view and add feature spec

* Refactor and add missing spec

---------

Co-authored-by: Nils Rauch <[email protected]>
@njaeggi @openscript
household person search adjustments (#836) (#887)
e893491 
* add serializer class attribute

* add feature spec to check for id and birth year search

* improve spec
@openscript
Merge branch 'master' into 767-people-import-1_people-umstellen-auf-c…
25cbcb9 
…sv-report-und-csv-source
@openscript
Merge branch 'master' into 767-people-import-1_people-umstellen-auf-c…
a49ed5d 
…sv-report-und-csv-source
@mtnstar
Copy link
Contributor

mtnstar commented Sep 3, 2024 

ActiveRecord::RecordNotUnique: PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "people_pkey" (ActiveRecord::RecordNotUnique)
DETAIL:  Key (id)=(99) already exists.

existiert eine Person bereits, gibt es einen constraint error.
sollte es dann nicht einfach die Person updaten? Im XLSX Import Script hatte es ein find_or_initialize aus diesem Grund.
Gibt es einen Grund das nicht mehr so zu handhaben?

@openscript
Copy link
Contributor Author

openscript commented Sep 3, 2024 •
edited
Loading

  • Truemail validiert via Regex während Importtask
  • Merge-Fehler beheben
  • find_or_initialize für mehrfache Ausführbarkeit

mtnstar
mtnstar previously requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@mtnstar mtnstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sieht soweit super aus 🥳

gerne teste ich den Import nochmals sobald alle Änderungen vorhanden sind 🚀

app/domain/sac_imports/csv_report.rb Show resolved Hide resolved
app/domain/sac_imports/csv_source.rb Show resolved Hide resolved
app/domain/sac_imports/people_importer.rb Show resolved Hide resolved
app/domain/sac_imports/person_entry.rb Show resolved Hide resolved
doc/import.md Show resolved Hide resolved
doc/import.md Outdated Show resolved Hide resolved
lib/tasks/sac_imports.rake Outdated Show resolved Hide resolved
spec/domain/sac_imports/membership_years_report_spec.rb Show resolved Hide resolved
@openscript openscript dismissed mtnstar’s stale review September 4, 2024 09:08

Approval in real life

@openscript openscript enabled auto-merge (squash) September 4, 2024 12:27
@openscript openscript merged commit 3336f29 into master Sep 4, 2024
5 checks passed
@openscript openscript deleted the 767-people-import-1_people-umstellen-auf-csv-report-und-csv-source branch September 4, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtnstar mtnstar mtnstar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PEOPLE: Import 1_people umstellen auf CSV-Report und CSV-Source
9 participants
@openscript @mtnstar @rnestler @hunchr @codez @njaeggi @kronn @amaierhofer @TheWalkingLeek