-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2665 Remove customized self inscription #860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
changed the title
Feature/2665 selfinscription wizard
Feature/2665 Remove customized self inscription
Aug 20, 2024
rnestler
force-pushed
the
feature/2665-selfinscription-wizard
branch
from
August 20, 2024 15:31
c2421de
to
94d3e47
Compare
4 tasks
rnestler
force-pushed
the
feature/2665-selfinscription-wizard
branch
3 times, most recently
from
August 22, 2024 17:21
cbce29a
to
f273ba2
Compare
amaierhofer
force-pushed
the
feature/2665-selfinscription-wizard
branch
from
August 23, 2024 08:12
f273ba2
to
b341d22
Compare
One of them seems unrelated to the changes and the other needs more time to debug. Not merging currently blocks development.
rnestler
commented
Aug 27, 2024
Comment on lines
-27
to
-34
def group_for_title | ||
role.class.name.ends_with?("::Neuanmeldung") ? @group.parent : @group | ||
end | ||
|
||
def neuanmeldung? | ||
@group.is_a?(Group::SektionsNeuanmeldungenSektion) || | ||
@group.is_a?(Group::SektionsNeuanmeldungenNv) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is related to the features/signup/sektion_spec.rb
spec failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: hitobito/hitobito#2665