Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEOPLE: Data quality checker #855

Merged
merged 8 commits into from
Aug 22, 2024
Merged

Conversation

hunchr
Copy link
Contributor

@hunchr hunchr commented Aug 19, 2024

Fixes #795

@hunchr hunchr self-assigned this Aug 19, 2024
@hunchr hunchr force-pushed the feature/795-people-data-quality branch 8 times, most recently from 67b0d17 to f12984f Compare August 20, 2024 14:17
@hunchr hunchr changed the title PEOPLE: Datenqualität überprüfen PEOPLE: Data quality checker Aug 21, 2024
@hunchr hunchr force-pushed the feature/795-people-data-quality branch 2 times, most recently from ed180b1 to 31880b9 Compare August 21, 2024 07:17
@hunchr hunchr marked this pull request as ready for review August 21, 2024 07:33
@hunchr hunchr force-pushed the feature/795-people-data-quality branch 2 times, most recently from 05efedb to adb2ff7 Compare August 21, 2024 12:35
@hunchr hunchr requested a review from njaeggi August 21, 2024 12:40
Copy link
Contributor

@njaeggi njaeggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good already 🚀

app/domain/people/data_quality_checker.rb Show resolved Hide resolved
app/models/sac_cas/person.rb Outdated Show resolved Hide resolved
@hunchr hunchr force-pushed the feature/795-people-data-quality branch from adb2ff7 to 0cb51b4 Compare August 21, 2024 14:51
@hunchr hunchr force-pushed the feature/795-people-data-quality branch from c2893b6 to 963a675 Compare August 22, 2024 07:06
@hunchr hunchr force-pushed the feature/795-people-data-quality branch 2 times, most recently from 1ed4558 to 67eaca0 Compare August 22, 2024 07:18
@hunchr hunchr force-pushed the feature/795-people-data-quality branch from 67eaca0 to 0782bec Compare August 22, 2024 07:18
@hunchr hunchr requested a review from njaeggi August 22, 2024 08:16
Copy link
Contributor

@njaeggi njaeggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@njaeggi njaeggi merged commit a1234c1 into master Aug 22, 2024
9 checks passed
@njaeggi njaeggi deleted the feature/795-people-data-quality branch August 22, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEOPLE: Überprüfung Datenqualität
2 participants