-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEOPLE: Data quality checker #855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunchr
force-pushed
the
feature/795-people-data-quality
branch
8 times, most recently
from
August 20, 2024 14:17
67b0d17
to
f12984f
Compare
hunchr
force-pushed
the
feature/795-people-data-quality
branch
2 times, most recently
from
August 21, 2024 07:17
ed180b1
to
31880b9
Compare
hunchr
force-pushed
the
feature/795-people-data-quality
branch
2 times, most recently
from
August 21, 2024 12:35
05efedb
to
adb2ff7
Compare
njaeggi
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good already 🚀
hunchr
force-pushed
the
feature/795-people-data-quality
branch
from
August 21, 2024 14:51
adb2ff7
to
0cb51b4
Compare
# Conflicts: # app/models/sac_cas/person.rb
hunchr
force-pushed
the
feature/795-people-data-quality
branch
from
August 22, 2024 07:06
c2893b6
to
963a675
Compare
hunchr
force-pushed
the
feature/795-people-data-quality
branch
2 times, most recently
from
August 22, 2024 07:18
1ed4558
to
67eaca0
Compare
hunchr
force-pushed
the
feature/795-people-data-quality
branch
from
August 22, 2024 07:18
67eaca0
to
0782bec
Compare
njaeggi
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #795