Feature/744/membership invoice form #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njaeggi
force-pushed
the
feature/744/membership-invoice-form
branch
from
f54e50b
to
a5ca1e2
Compare
amaierhofer
force-pushed
the
feature/744/membership-invoice-form
branch
from
71b4c05
to
626d4c9
Compare
amaierhofer
previously requested changes
Aug 16, 2024
njaeggi
force-pushed
the
feature/744/membership-invoice-form
branch
2 times, most recently
from
a7820a8
to
9fc8f2f
Compare
amaierhofer
force-pushed
the
feature/744/membership-invoice-form
branch
from
408f9dd
to
33c21fd
Compare
njaeggi
force-pushed
the
feature/744/membership-invoice-form
branch
from
7c3f5c1
to
60a6f8f
Compare
amaierhofer
added a commit
that referenced
this pull request
Aug 21, 2024
* create form and adjsut controller to create external invoice with passed params * imrpove validation of passed params * fix rubocop and cleanup code * Adjust form validation to use active model * remove trailing whitespaces * Add acitve model to validate membership invoice * fix rubocop and adjust translations * change to standard form * implement review * adjust specs and fix rubocop * Some hopefully safe refactorings * Some more refactorings * further cleanup and add some additional specs * Render instead of redirect * further refactoring * cleanup currently_paying method filter * adjust methods in invoice form --------- Co-authored-by: Andreas Maierhofer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #744
ref core pr: hitobito/hitobito#2761