Store household key on role for family memberships (#1232) #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
TheWalkingLeek
requested changes
Nov 18, 2024
| @@ -16,7 +16,10 @@ class Mitglied < ::Role | |||
|
|
|||
| validates :end_on, presence: true | |||
|
|
|||
There was a problem hiding this comment.
Hier fehlt noch entweder ein attribute :family_id oder eine Migration die eine neue DB Spalte einfügt. ist aber gar nicht so genau gespez'd
There was a problem hiding this comment.
Danke nils, ich dachte das gäbs schon, hab die migration ergänzt und in der spec noch ein reload gemacht
amaierhofer
force-pushed
the
feature/1232-set-family-id-on-role-for-family-memberships
branch
from
9f03eb6
to
1d8c0ee
Compare
TheWalkingLeek
approved these changes
Nov 19, 2024
amaierhofer
force-pushed
the
feature/1232-set-family-id-on-role-for-family-memberships
branch
from
1d8c0ee
to
9b56e48
Compare
amaierhofer
deleted the
feature/1232-set-family-id-on-role-for-family-memberships
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.