Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add loading state for message sending and fix multiple message sends #183

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jawad-Ali2
Copy link

I noticed that sending a message in the chat app takes around 1-2 seconds, but there was no visual indication that the message was being sent. This can lead to confusion for users, as they might not be sure if their message has been sent, especially if they press enter multiple times.

To improve the user experience, I have added a loading state to visualize the message sending process. This loading state appears when a user sends a message and provides immediate feedback that the message is being processed.

Additionally, I discovered that if the user spams the enter key three times, multiple identical messages were sent. I have fixed this issue to ensure that only one message is sent, even if the enter key is pressed multiple times quickly.

Benefits:

  • Enhances user experience by providing clear feedback.
  • Reduces user uncertainty about message sending.
  • Prevents unnecessary re-sending attempts by users.
  • Fixes the issue of multiple identical messages being sent when the enter key is spammed.

Testing:

  • Verified that the loading state appears when a message is being sent.
  • Confirmed that the message is only sent once, even if the enter key is pressed multiple times quickly.

@Jawad-Ali2 Jawad-Ali2 changed the title Add loading state for message sending and fix multiple message sends fix: add loading state for message sending and fix multiple message sends Jul 5, 2024
@wajeshubham
Copy link
Collaborator

@Jawad-Ali2 Thanks for the PR. For better understanding kindly attach demo video of changes you've made in the UI so that we know that the added code is working. Also, resolve conflicts in the respective branch. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants