Upgrade to Moodle 2.9 API, use core_text. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…$eventdata->files) is an array.
|
I added another commit to this pull request, that fixed moss_save_storedfiles for Moodle 2.9. |
It seems that you cannot run moss measure() in any other way --- it is run only from cron, and timetomeasure is set only from admin options. Moss will *not* automatically run on due time. So fix the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moodle 2.9 requires using core_text:::xxx functions. Right now entering plagiarism/moss/settings.php page fails with error
textlib_get_instance() can not be used any more, please use core_text::functioname() instead.
Submitting a simple fix. Other Moodle modules applied similar fixes, see e.g. patrickpollet/moodle_local_ldap#9 and jleyva/moodle-local_ltiprovider@9fefa6b .
This fix seems to work fine for our Moodle 2.9.2+ (from 2015-09-18) installation + Moss.