Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.13.0 #303

Merged
merged 9 commits into from
Dec 4, 2017
Merged

2.13.0 #303

merged 9 commits into from
Dec 4, 2017

Commits on Mar 7, 2016

  1. Bump node-xmpp-client to ^3.0.0

    Sam Day committed Mar 7, 2016
    Configuration menu
    Copy the full SHA
    52acaef View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2016

  1. Simplify sending and return users from the brain

    The Hubot Hipchat adapter uses the `envelope.user.reply_to` property as
    the primary way for determining where a message should get sent. This
    does not appear to be necessary. It is an abnormal pattern that doesn't
    seem to be in any other popular adapters (Slack, Campfire). Perhaps this
    was necessary on some older versions of Hubot and was never updated.
    
    The `envelope.room` property seems to have all it needs to send the
    message to the right place. Removing the `reply_to` logic simplifies
    things quite a bit. This change also helps with hipchat#175 where messages
    would get sent to the wrong origins for some long running processes if
    the user happens to send a message in another room before the process
    can finish.
    
    The fix for the above problem in hipchat#207 broke the brain some. Typically,
    in other adapters, the `message.user` object returned will be a
    reference to the brain. Here, you can store data that you would want to
    persist. By cloning this object it breaks that ability and can affect
    plugins expecting that behavior.
    
    Found this issue while working with the `hubot-pager-me` plugin. This
    plugin assumes the `message.user` property is from the brain. When
    doing things like `pager me as [email protected]` it assigns it to that
    property where it should persist but does not. This does work in other
    adapters though like Shell and Campfire.
    
    Finally, one other added benefit these changes bring are a level of
    consistency to the `user.room` property. When `changePresence()` was
    called it would populate the brain and set the room to the JID version
    which looks something like `[email protected]`. When a
    message was getting handled it would filter the room through
    `roomNameFromJid()` which would transform the room name to a friendlier
    format like `foo_bar`. Now, the `user.room` property will always bet set
    to the JID version.
    awiddersheim committed Jun 10, 2016
    Configuration menu
    Copy the full SHA
    bc41194 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2017

  1. Bump package version

    Ben Hanzl committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    d35bc49 View commit details
    Browse the repository at this point in the history
  2. Add a changelog

    Ben Hanzl committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    c1617a3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    382b807 View commit details
    Browse the repository at this point in the history
  4. Bump node-xmpp-client to 3.2.0

    Ben Hanzl committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    364a289 View commit details
    Browse the repository at this point in the history
  5. Update changelog

    Ben Hanzl committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    e0a7544 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2017

  1. Update changelog for 2.13.0

    Ben Hanzl committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    82a5195 View commit details
    Browse the repository at this point in the history
  2. Commit package-lock (recommended by npm)

    Ben Hanzl committed Nov 21, 2017
    Configuration menu
    Copy the full SHA
    c10ab86 View commit details
    Browse the repository at this point in the history