Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the processing of rooms. #280

Closed
wants to merge 8 commits into from
Closed

Fix the processing of rooms. #280

wants to merge 8 commits into from

Conversation

178inaba
Copy link

Can get the name of the after the rename.
msg.message.room

messageRoom was also to make it work.

Help specifies the private room in the user's name.
https://github.com/hubot-scripts/hubot-help/blob/master/src/help.coffee#L76

Hubot user have only the name.
https://github.com/github/hubot/blob/master/src/user.coffee#L9

So I get the JID from the name.

@rbergman I'd like a merge and npm release!

@rbergman
Copy link
Contributor

My ability to actively maintain this is practically nil now. If someone wants to fork this repo, curate the open PRs by merging and manually testing them in a production Hubot so we can be sure they're well vetted, I'd be happy to accept aggregate PRs here and publish to npm. I don't have an effective way to test on a production Hubot any more with the (lack of) time I have available for side projects, unfortunately.

@178inaba
Copy link
Author

178inaba commented Sep 5, 2016

@rbergman Thanks for the reply!
I do not even have time to test the other pull request.
But, I have tested this pull request by production Hubot.

Test was carried out by editing the package.json as follows:

{
  ...
  "dependencies": {
    ...
    "hubot-hipchat": "178inaba/hubot-hipchat#rooms",
    ...
  },
  ...
}

I was sure that my pull request is not a problem.

@Wilfred
Copy link

Wilfred commented Nov 22, 2017

@rbergman there's a great PR at #303 that does exactly that: it's merged the PRs, tested them against a production instance and proposed a new release. Would you be able to merge them and/or give @benhanzl commit powers?

@178inaba 178inaba closed this Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants