-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the processing of rooms. #280
Conversation
My ability to actively maintain this is practically nil now. If someone wants to fork this repo, curate the open PRs by merging and manually testing them in a production Hubot so we can be sure they're well vetted, I'd be happy to accept aggregate PRs here and publish to npm. I don't have an effective way to test on a production Hubot any more with the (lack of) time I have available for side projects, unfortunately. |
@rbergman Thanks for the reply! Test was carried out by editing the package.json as follows: {
...
"dependencies": {
...
"hubot-hipchat": "178inaba/hubot-hipchat#rooms",
...
},
...
} I was sure that my pull request is not a problem. |
Can get the name of the after the rename.
msg.message.room
messageRoom
was also to make it work.Help specifies the private room in the user's name.
https://github.com/hubot-scripts/hubot-help/blob/master/src/help.coffee#L76
Hubot user have only the name.
https://github.com/github/hubot/blob/master/src/user.coffee#L9
So I get the JID from the name.
@rbergman I'd like a merge and npm release!