-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the sso code in Rust #335
Conversation
This doesn't actually work yet. In testing, the Rust binary behaves exactly the same in the terminal, but the SSO browser plugin terminates the connection for some reason. |
I'm pretty sure this is related to the line-format that is passed via stdin / stdout. The native messaging protocol is VERY picky about the data that is transferred. |
I have tested your implementation on my local machine in Firefox, and it worked fine for me. The native messages also match bit by bit as far as I have seen. Maybe some mistakes were made in your test setup? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also had a build failure, the new_v4
was not available from the uuid
crate. I needed to enable the v4
feature for it.
It's enabled by my Himmelblau workspace, which is why it worked for me. If you build it individually, it fails in this way. |
4590679
to
23d654c
Compare
Perhaps I should be using a native messaging library, rather than re-inventing the wheel. |
Signed-off-by: David Mulder <[email protected]>
23d654c
to
58a726a
Compare
I tried using this existing native messaging library, but it does not work. It sent the message wrapped in quotes, and the browser plugin couldn't parse it. I ended up getting my original implementation to work, so I'll stick with it. |
This rewrites the Python3 SSO code in Rust.