Include multi-domain important info in himmelblau.conf man #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #314 Signed-off-by: David Mulder <[email protected]>
There was a typo in the hsm type parsing. Signed-off-by: David Mulder <[email protected]>
The list of domains was being sorted, mixing up the default domain and causing it to be whichever came first alphabetically. Signed-off-by: David Mulder <[email protected]>
To prevent mistakes in the configuration in the future, adding unit tests so we are checking that these are handled correctly. Signed-off-by: David Mulder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314
Fixes #
Checklist