Government tenant fixes #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The graph url isn't always the default. US gov tenants (amoung possibly others) utilize a different graph url. BUG: #291 Signed-off-by: David Mulder <[email protected]>
A 15 second timeout ensures banned users are
forgotten almost immediately, but it also
drammatically increases network traffic, slows
down Himmelblau, and causes AADSTS50196 errors on
some tenants ("The server terminated an operation
because it encountered a client request loop").
A 5 minute timeout is more reasonable, and
mirrors Winbind's behavior. This timeout can
be decreased via configuration if necessary.
BUG: #290
Signed-off-by: David Mulder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291
Fixes #290
Checklist