Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile #253

Closed
wants to merge 2 commits into from
Closed

Update Makefile #253

wants to merge 2 commits into from

Conversation

barkermn01
Copy link
Contributor

Updated make file install-ubuntu now copies libpam_himmelblau.so to /usr/lib/security/pam_himmelblau.so

Fixes #251

Checklist

  • This pr contains no AI generated code
  • cargo fmt has been run
  • cargo clippy has been run
  • A functionality test has been added
  • make test has been run and passes

@barkermn01
Update Makefile
fd4f06f 
Updated make file to fix: himmelblau-idm#251
dmulder
dmulder requested changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@dmulder dmulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should symlink it instead.
ln -s /usr/lib/x86_64-linux-gnu/security/pam_himmelblau.so /usr/lib/security/pam_himmelblau.so, but maybe check if /usr/lib/security exists first.

@dmulder
Copy link
Collaborator

dmulder commented Oct 15, 2024

See here: #256

@dmulder dmulder closed this Oct 15, 2024
@barkermn01 barkermn01 deleted the barkermn01-fix-251 branch October 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmulder dmulder dmulder requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make install is not working on Ubuntu
2 participants
@barkermn01 @dmulder