Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updates to Integer API #102

Merged
merged 2 commits into from
Aug 6, 2024
Merged

refactor: updates to Integer API #102

merged 2 commits into from
Aug 6, 2024

Conversation

hiltontj
Copy link
Owner

@hiltontj hiltontj commented Aug 4, 2024

Closes #101

@hiltontj hiltontj self-assigned this Aug 4, 2024
@hiltontj hiltontj marked this pull request as ready for review August 4, 2024 22:27
@hiltontj
Copy link
Owner Author

hiltontj commented Aug 4, 2024

@Marcono1234 - fancy taking a look at this?

Copy link
Contributor

@Marcono1234 Marcono1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I have added some comments, but I am not that familiar with Rust best practices, so feel free to ignore the comments.

serde_json_path_core/src/spec/integer.rs Show resolved Hide resolved
serde_json_path_core/src/spec/integer.rs Outdated Show resolved Hide resolved
serde_json_path_core/src/spec/integer.rs Outdated Show resolved Hide resolved
@hiltontj
Copy link
Owner Author

hiltontj commented Aug 6, 2024

Thank you for the feedback @Marcono1234!

@hiltontj hiltontj merged commit 3b096de into main Aug 6, 2024
5 checks passed
@hiltontj hiltontj deleted the refactor-integer branch August 6, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Integer API
2 participants