Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add urls and views #20

Open
wants to merge 8 commits into
base: draft-16-master
Choose a base branch
from

Conversation

jjdelc
Copy link

@jjdelc jjdelc commented Mar 14, 2012

Adding oauth2app a views module and pluggable url patterns.

Updated the example project to use those.

@bhagany
Copy link
Member

bhagany commented Mar 15, 2012

Some sort of strangeness here - github won't let me automatically merge this. Kind of makes me nervous, but I don't immediately understand why, unless it's because there are commits that have already been made in the pul request?

@pydanny
Copy link

pydanny commented Mar 18, 2012

IMO, Github auto-merges should only be used on documentation changes, not for logic/functionality changes.

@pydanny
Copy link

pydanny commented Mar 19, 2012

Upon review, this should be merged in. I don't have rights, but it looks very solid to me.

@jjdelc
Copy link
Author

jjdelc commented Mar 19, 2012

Sorry guys, I've been offline during hte week, I'll go ahead and do a request without the duplicate commits.

@bhagany
Copy link
Member

bhagany commented Mar 19, 2012

Apologies here too, I've had a pretty busy half-week or so.

@jonas-grgt
Copy link

This should be merged in, why hasn't this been merged in yet ?

@bhagany
Copy link
Member

bhagany commented Oct 15, 2012

As you can see in the comments, I was left expecting an updated request without duplicate commits, and so dropped it.

@bhagany
Copy link
Member

bhagany commented Oct 15, 2012

The patch also removes simplejson as a dependency, and while I can sympathize with that goal, it has a few effects that I'm not sure I can support -

  • it wouldn't support older python versions
  • removes any hope for automatic Decimal serialization, which isn't there now, but I think it would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants