Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add blog for e2e debug #195

Merged
merged 7 commits into from
Dec 22, 2023
Merged

add blog for e2e debug #195

merged 7 commits into from
Dec 22, 2023

Conversation

sjcsjc123
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@johnlanni
Copy link
Contributor

请 @CH3CHO 一并看看，给些建议

@sjcsjc123
Copy link
Contributor Author

@johnlanni 已修改

johnlanni
johnlanni approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@sjcsjc123 sjcsjc123 marked this pull request as draft December 20, 2023 02:36
@sjcsjc123 sjcsjc123 marked this pull request as ready for review December 20, 2023 13:32
@sjcsjc123
Copy link
Contributor Author

It is ok.

@johnlanni
Copy link
Contributor

image
这里可以加一篇，内容里面链接到这篇blog不

@sjcsjc123
Copy link
Contributor Author

image
是这样吗，貌似不生效，想着让文档里的md能够完全展示出来blog里的内容。

@johnlanni
Copy link
Contributor

直接加个链接地址就行

@sjcsjc123
Copy link
Contributor Author

已修改

johnlanni
johnlanni approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni
Copy link
Contributor

image
@sjcsjc123 CI失败了

@johnlanni
Copy link
Contributor

简单一些，用http链接也可以

@johnlanni johnlanni merged commit b9ed9e8 into higress-group:main Dec 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnlanni johnlanni johnlanni approved these changes

@laojun laojun Awaiting requested review from laojun

@CH3CHO CH3CHO Awaiting requested review from CH3CHO

@slievrly slievrly Awaiting requested review from slievrly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjcsjc123 @CLAassistant @johnlanni