fixup! [HIG] add Highlight features for rrweb

highlight · Mar 5, 2024 · 0d5cd39 · 0d5cd39
1 parent 11a7526
commit 0d5cd39
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/rrdom/src/index.ts b/packages/rrdom/src/index.ts
@@ -305,7 +305,7 @@ export function buildFromDom(
       // if the parentRRNode isn't a RRIFrameElement
       parentRRNode?.nodeName !== 'IFRAME' &&
       // if node isn't a shadow root
-      node.nodeType !== NodeType.DOCUMENT_FRAGMENT_NODE
+      (node.nodeType as NodeType) !== NodeType.DOCUMENT_FRAGMENT_NODE
     ) {
       parentRRNode?.appendChild(rrNode);
       rrNode.parentNode = parentRRNode;
@@ -316,13 +316,13 @@ export function buildFromDom(
       const iframeDoc = (node as HTMLIFrameElement).contentDocument;
       iframeDoc && walk(iframeDoc, rrNode);
     } else if (
-      node.nodeType === NodeType.DOCUMENT_NODE ||
-      node.nodeType === NodeType.ELEMENT_NODE ||
-      node.nodeType === NodeType.DOCUMENT_FRAGMENT_NODE
+      (node.nodeType as NodeType) === NodeType.DOCUMENT_NODE ||
+      (node.nodeType as NodeType) === NodeType.ELEMENT_NODE ||
+      (node.nodeType as NodeType) === NodeType.DOCUMENT_FRAGMENT_NODE
     ) {
       // if the node is a shadow dom
       if (
-        node.nodeType === NodeType.ELEMENT_NODE &&
+        (node.nodeType as NodeType) === NodeType.ELEMENT_NODE &&
         (node as HTMLElement).shadowRoot
       )
         // eslint-disable-next-line @typescript-eslint/no-non-null-assertion

diff --git a/packages/rrweb-player/package.json b/packages/rrweb-player/package.json
@@ -5,7 +5,9 @@
     "@rollup/plugin-commonjs": "^22.0.0",
     "@rollup/plugin-node-resolve": "^13.2.1",
     "@rrweb/types": "workspace:*",
+    "@types/eslint": "^8",
     "@types/offscreencanvas": "^2019.6.4",
+    "eslint": "^8.57.0",
     "eslint-config-google": "^0.14.0",
     "eslint-plugin-svelte3": "^4.0.0",
     "postcss-easy-import": "^3.0.0",