upgrade to go 1.20 #5217
Merged
upgrade to go 1.20 #5217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
et
commented
May 3, 2023
et
requested review from
a team,
ccschmitz and
Vadman97
and removed request for
a team
Vadman97
reviewed
May 5, 2023
Correct me if I'm wrong but isn't it using the same thing? highlight/.github/workflows/backend.yml Lines 18 to 19 in 4cac399 |
@et I think there are still some CI files where we are hard-coded to https://github.com/search?q=repo%3Ahighlight%2Fhighlight+%271.19%27&type=code Looks good to me otherwise - thanks for upgrading us! |
Vadman97
approved these changes
May 5, 2023
added 2 commits
May 8, 2023 08:55
Indeed. Just pushed some changes to fix some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to upgrade?
Homebrew
brew install [email protected]Other Go installations
https://go.dev/dl
Summary
This PR upgrades us to Go 1.20 (release notes). The reasoning behind the upgrade is obviously to be on the latest and greatest but also to help prove we don't need the deprecated github.com/pkg/errors library. Specifically, Go 1.20 has a built-in
errors.Joinfunction that does what theerrors.Wrapfunction was doing.As we have discussed over slack, Go error wrapping is unnecessary assuming there's an associated stack trace. Long term, I still plan on removing all of the error wrapping in our code base but wanted to make that distinct from the Go upgrade.
How did you test this change?
Updated our docs to reflect that Go 1.20 is now the minimum version. We don't specify how to install Go but for most of us, it's probably
brew install [email protected](other versions here) and restart the backend.I did a basic click test and didn't observe any issues. I didn't notice any breaking changes from the release notes either.
Are there any deployment considerations?
N/A