Send multiple JOIN commands if 512 bytes message length is violated #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As messages are limited to 512 bytes including CR/LF, the JOIN command fails if the amount of channels intended to be joined is too large. This commit allows joining a larger number of rooms by splitting the channels to be joined among multiple JOIN commands instead of running only one join commands which violates the message length.
e-luks
force-pushed
the
feature/join_many_channels
branch
from
c8386d6
to
6a8ed64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As messages are limited to 512 bytes including CR/LF, the JOIN command fails if the amount of channels intended to be joined is too large.
This commit allows joining a larger number of rooms by splitting the channels to be joined among multiple JOIN commands instead of running only one join commands which violates the message length.