Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overloaded init methods that take the public key from a stream an… #908

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Oct 23, 2023

…d properly initialize. Resolves #907.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Attention: Patch coverage is 45.00000% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 68.50%. Comparing base (03f8b22) to head (17fe2ab).
Report is 8 commits behind head on master.

❗ Current head 17fe2ab differs from pull request most recent head 9edc75f. Consider uploading reports for the commit 9edc75f to get more accurate results

Files Patch % Lines
...sshj/userauth/keyprovider/OpenSSHKeyV1KeyFile.java 23.52% 11 Missing and 2 partials ⚠️
...sshj/userauth/keyprovider/BaseFileKeyProvider.java 61.53% 2 Missing and 3 partials ⚠️
...mizz/sshj/userauth/keyprovider/OpenSSHKeyFile.java 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #908      +/-   ##
============================================
- Coverage     68.96%   68.50%   -0.47%     
+ Complexity     1448     1416      -32     
============================================
  Files           208      207       -1     
  Lines          7602     7529      -73     
  Branches        658      642      -16     
============================================
- Hits           5243     5158      -85     
- Misses         2009     2028      +19     
+ Partials        350      343       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkocher dkocher marked this pull request as draft October 23, 2023 20:48
@dkocher dkocher force-pushed the issue/907 branch 3 times, most recently from 30c402e to 17fe2ab Compare October 23, 2023 21:11
@dkocher
Copy link
Contributor Author

dkocher commented Oct 23, 2023

Not sure how to update the code coverage report with updated results from the force pushed commit.

@dkocher dkocher marked this pull request as ready for review October 23, 2023 21:15
@hierynomus
Copy link
Owner

@dkocher if you can bring this back up to date with the base branch, and see whether coverage can be improved slightly to make the codecov happy, I'll merge this so that we can bring out a new version.

@hierynomus hierynomus merged commit 09e2ca5 into hierynomus:master Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No initialization of public key depending on constructor usage of file key provider
4 participants