Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #745 #753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Issue #745 #753

wants to merge 1 commit into from

Conversation

hannosgit
Copy link
Contributor

Attempts to fix issue #745 "Change mkdirs to static" with the implementation proposed in the comments of the PR.

@hannosgit hannosgit requested a review from hierynomus as a code owner March 18, 2023 18:35
@hannosgit
Copy link
Contributor Author

hannosgit commented Mar 18, 2023 •
edited
Loading

Should we also create the copy method in the new util class?

@neon-dev neon-dev mentioned this pull request Apr 5, 2023
Closed
@neon-dev
Copy link

neon-dev commented Apr 5, 2023 •
edited
Loading

I was a bit hasty and created #757. I'd suggest implementing the pathIsFile boolean here.
Also, why not copy all the code over from SmbFiles and deprecate the old class entirely? This would also simplify deleting it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hierynomus hierynomus Awaiting requested review from hierynomus hierynomus is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannosgit @neon-dev