Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce new mechanism for key setting when creating an account #2188

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: introduce new mechanism for key setting when creating an account #2188

wants to merge 17 commits into from

Conversation

naydenovn
Copy link
Contributor

@naydenovn naydenovn commented Jan 20, 2025 •
edited by 0xivanov
Loading

Description:
introduce new mechanism for key setting when creating an account

Related issue(s):

Fixes #2177

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@naydenovn naydenovn requested a review from 0xivanov January 20, 2025 13:19
@naydenovn naydenovn self-assigned this Jan 20, 2025
@naydenovn naydenovn requested a review from a team as a code owner January 20, 2025 13:19
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.74%. Comparing base (b86ee46) to head (9cc35c8).
Report is 233 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2188      +/-   ##
============================================
- Coverage     82.20%   78.74%   -3.46%     
- Complexity     3588     4101     +513     
============================================
  Files           186      243      +57     
  Lines         11697    13764    +2067     
  Branches       1150     1337     +187     
============================================
+ Hits           9615    10838    +1223     
- Misses         1604     2454     +850     
+ Partials        478      472       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0xivanov and others added 3 commits January 24, 2025 13:13
@0xivanov
chore: refactor
90512cd 
Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov
chore: make key a constant
1d249ab 
Signed-off-by: Ivan Ivanov <[email protected]>
@naydenovn
fix: spotlessApply
b6686ec 
Signed-off-by: Naydenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xivanov 0xivanov 0xivanov left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@naydenovn naydenovn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streamline key and alias specifications for AccountCreateTransaction
2 participants
@naydenovn @0xivanov