Mpi auth #36
Open
Mpi auth #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show new covered files 🐣
Test suite run success4 tests passing in 2 suites. Report generated by 🧪jest coverage report action from e728551 |
cbolles
requested changes
Sep 13, 2024
|
|
||
| type eLabsStatus = 'PENDING' | 'PROGRESS' | 'COMPLETED'; | ||
|
|
||
| @Controller('mpi') |
There was a problem hiding this comment.
Is there a reason this is written using REST instead of GraphQL?
There was a problem hiding this comment.
I suppose just to reflect the MPI backend
|
|
||
| @Injectable() | ||
| export class MPIService { | ||
| private tokenStore = new Map<string, { accessToken: string; refreshToken: string; accessTokenExpiration: Date }>(); |
There was a problem hiding this comment.
This should probably be within MongoDB since we already have everything setup for it
| const user = this.tokenStore.get(this.currentUserId); | ||
| if (user && user.accessToken && user.accessTokenExpiration) { | ||
| if (user.accessTokenExpiration > new Date(Date.now())) { | ||
| console.log('user ', user, ' has valid token'); |
There was a problem hiding this comment.
Best to avoid having left over console.logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist