Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreatePollVote command #9994

Merged
merged 9 commits into from
Nov 21, 2024
Merged

CreatePollVote command #9994

merged 9 commits into from
Nov 21, 2024

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Nov 20, 2024 •
edited
Loading

Link to Issue

Closes: #9986

Description of Changes

  • Migrated update_poll_vote to CreatePollVote.command
  • Added the UPDATE_POLL permission by default in create group and update group commands

Test Plan

  • Create a group that you are a part of
  • Create a thread
  • Create a poll
  • Vote on the poll

Deployment Plan

Other Considerations

@timolegros timolegros marked this pull request as ready for review November 21, 2024 18:28
@ilijabojanovic
Copy link
Collaborator

@timolegros pls fix lint issues

@timolegros timolegros merged commit a6aec4d into master Nov 21, 2024
10 checks passed
@timolegros timolegros deleted the tim/9986.fix-poll-vote branch November 21, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@ilijabojanovic ilijabojanovic ilijabojanovic approved these changes

@kurtisassad kurtisassad Awaiting requested review from kurtisassad

@mzparacha mzparacha Awaiting requested review from mzparacha

@rbennettcw rbennettcw Awaiting requested review from rbennettcw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to vote on thread poll
3 participants
@timolegros @ilijabojanovic @Rotorsoft