Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autovote on contests #9993

Merged
merged 19 commits into from
Nov 25, 2024
Merged

Autovote on contests #9993

merged 19 commits into from
Nov 25, 2024

Conversation

rbennettcw
Copy link
Contributor

@rbennettcw rbennettcw commented Nov 20, 2024 •
edited
Loading

Link to Issue

Closes: #9922

Description of Changes

  • Automatically votes on contests that don't have votes and will end soon
  • Fixes contest worker test

Test Plan

  • Unit test covers condition that will trigger onchain vote

Deployment Plan

N/A

Other Considerations

  • Private key is CI is a burner

@rbennettcw rbennettcw marked this pull request as draft November 20, 2024 23:43
@rbennettcw rbennettcw marked this pull request as ready for review November 21, 2024 20:30
Rotorsoft
Rotorsoft approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Rotorsoft Rotorsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending some minor naming comments

@rbennettcw
Copy link
Contributor Author

Added ticket to implement scheduler in the future: #10017

kurtisassad
kurtisassad approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@kurtisassad kurtisassad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to merge in master to get the updated CI otherwise you won't be able to merge this PR

@masvelio
Copy link
Contributor

please remove the flag on the frontend #9922 (comment)

@rbennettcw rbennettcw merged commit 2f60d2f into master Nov 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@kurtisassad kurtisassad kurtisassad approved these changes

@timolegros timolegros Awaiting requested review from timolegros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zero weight upvote for contests with no votes
4 participants
@rbennettcw @masvelio @kurtisassad @Rotorsoft