Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launchpad improvements #9965

Merged
merged 9 commits into from
Nov 25, 2024
Merged

Launchpad improvements #9965

merged 9 commits into from
Nov 25, 2024

Conversation

mzparacha
Copy link
Contributor

@mzparacha mzparacha commented Nov 20, 2024

Link to Issue

Closes: #9970

Description of Changes

  • Prevents user from leaving trades modal when any action is pending
  • Only shows draft clear message when there are more than 1 token drafts in quick token launch form
  • Require auth before opening quick token launch form from communities page
  • Correctly refetech user's selected address eth/token balance and eth->token, token->eth exchange rates after a buy or a sell trade.

"How We Fixed It"

N/A

Test Plan

  1. Verify no regressions.
  2. Verify user is prevented from leaving trades modal when any action is pending
  3. Verify you only see the token draft clear message when there are more than 1 token drafts in quick token launch form
  4. Verify you are required to authenticate before opening quick token launch form from communities page
  5. Verify that after a buy/sell trade, the eth+token (that you bought/sold) balance gets updated correctly for your selected address, and the exchange rates also update correctly.
  6. Verify that after a buy/sell trade, the token pricing updates in the community token trade widget and in the communities page tokens listing
  7. Verify the tokens list in communities page refreshes when a token is created.

Deployment Plan

N/A

Other Considerations

N/A

@github-actions github-actions bot marked this pull request as draft November 20, 2024 13:11
@mzparacha mzparacha self-assigned this Nov 22, 2024
@mzparacha mzparacha marked this pull request as ready for review November 22, 2024 10:26
@mzparacha mzparacha changed the title Malik.launchpad improvements Launchpad improvements Nov 22, 2024
@mzparacha
Copy link
Contributor Author

mzparacha commented Nov 22, 2024

Update: there is a bug with trpc not invalidating cache correctly, this affects test cases 6 and 7 from OP. I am finding a solution for that, and atm this commit is where the invalidation for 6/7 happens. The other things specified in OP should work correctly.

cc: @masvelio @Israellund

@mzparacha mzparacha merged commit 5775e4a into master Nov 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA launchpad + Identify/Fix Bugs
3 participants