-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launchpad improvements #9965
Merged
Merged
Launchpad improvements #9965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzparacha
commented
Nov 20, 2024
packages/commonwealth/client/scripts/hooks/useDeferredConditionTriggerCallback.ts
Show resolved
Hide resolved
Update: there is a bug with trpc not invalidating cache correctly, this affects test cases 6 and 7 from OP. I am finding a solution for that, and atm this commit is where the invalidation for 6/7 happens. The other things specified in OP should work correctly. cc: @masvelio @Israellund |
Israellund
approved these changes
Nov 22, 2024
masvelio
approved these changes
Nov 22, 2024
packages/commonwealth/client/scripts/state/api/launchPad/buyToken.ts
Outdated
Show resolved
Hide resolved
packages/commonwealth/client/scripts/state/api/launchPad/tokenEthExchangeRate.ts
Show resolved
Hide resolved
packages/commonwealth/client/scripts/state/api/launchPad/buyToken.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9970
Description of Changes
"How We Fixed It"
N/A
Test Plan
Deployment Plan
N/A
Other Considerations
N/A