made the community page scrollable #9955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not able to replicate the original issue for some reason, can you check if its still reproducible on cc: @KaleemNeslit |
just pull the master and i am able to produce the issue .here is the video @mzparacha Screen.Recording.2024-11-21.at.8.32.43.PM.mov |
mzparacha
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Still not able to reproduce but i think the changes are fine.
cc: @KaleemNeslit
masvelio
approved these changes
Nov 25, 2024
… into kaleemNeslit.9939.explore_community_page
… into kaleemNeslit.9939.explore_community_page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9939
Description of Changes
"How We Fixed It"
made the Explore Communities full page scrollable
Test Plan
Goto Explore Communities page and try to scrolll the full page
Screen.Recording.2024-11-19.at.8.46.08.PM.mov