Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added token trading widget inside community sidebar #9951

Merged
merged 10 commits into from
Nov 21, 2024

Conversation

mzparacha
Copy link
Contributor

@mzparacha mzparacha commented Nov 19, 2024

Link to Issue

Closes: #9489 #9946

Description of Changes

Added token trading widget inside the community sidebar

"How We Fixed It"

N/A

Test Plan

Pre-req: there were some changes to tokens schema and contract in earlier prs that will result in non-valid values with existing tokens (if you have any created in local db). You'd need to clear those out, i.e first clear the LaunchpadTrades and then the Tokens table, create a new token and then you'd be able to test correctly.

  1. Visit any community that has a token
  2. Verify you see the community token loaded as a widget in the community sidebar
  3. Verify you are able to trade (buy/sell) token from that widget
  4. Verify that token pricing data and market caps displayed are correct

Deployment Plan

N/A

Other Considerations

N/A

@github-actions github-actions bot marked this pull request as draft November 19, 2024 13:08
@mzparacha mzparacha self-assigned this Nov 19, 2024
@mzparacha
Copy link
Contributor Author

Depends on some changes from #9905

@mzparacha mzparacha marked this pull request as ready for review November 20, 2024 16:52
@mzparacha mzparacha linked an issue Nov 21, 2024 that may be closed by this pull request
@mzparacha mzparacha merged commit 2a4c3b8 into master Nov 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gracefully display fractional token prices Buy / Sell within Community
3 participants