Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Israel.9746.allowlist changes #9903

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Israellund
Copy link
Collaborator

Link to Issue

Closes: #9746

Description of Changes

  • Changed Create Group UI and removed allowList as a requirement on the backend.

@@ -43,21 +43,11 @@ const ThresholdData = z.object({
]),
});

const AllowlistData = z.object({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we don't support allow lists any more?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading the ticket, it's not clear to me we want to remove the allow list schema.

@Israellund
Copy link
Collaborator Author

@Rotorsoft Not sure where to remove the allowlist as part of the requirements. Is there somewhere else you would suggest it be removed?

@Rotorsoft
Copy link
Contributor

@Rotorsoft Not sure where to remove the allowlist as part of the requirements. Is there somewhere else you would suggest it be removed?

I guess we are still supporting allow lists, but these requirements should be optional.
If that's the case, you need to find a way to pass the intent to the API, either when creating or modifying groups security, by passing undefined or empty requirements to those mutations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow list being a requirement is not clear in the UI
2 participants