Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kaleem neslit.9859.profile loading #9861

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Kaleem neslit.9859.profile loading #9861

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0ca380
Merge branch 'master' of https://github.com/hicommonwealth/commonwealth
KaleemNeslit Nov 6, 2024
6ef8ca6
Merge branch 'master' of https://github.com/hicommonwealth/commonwealth
KaleemNeslit Nov 7, 2024
3ea1a08
fixed the loading issue
KaleemNeslit Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions packages/commonwealth/client/scripts/views/components/user/fullUser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,12 @@ export const FullUser = ({
const loggedInUser = useUserStore();
const [isModalOpen, setIsModalOpen] = useState(false);

const { data: userCommunity, isLoading: isLoadingUserCommunity } =
useGetCommunityByIdQuery({
id: userCommunityId || '',
enabled: !!userCommunityId,
});
const { data: userCommunity } = useGetCommunityByIdQuery({
id: userCommunityId || '',
enabled: !!userCommunityId,
});

if (showSkeleton || isLoadingUserCommunity) {
if (showSkeleton) {
Comment on lines +47 to +52
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would break in many cases. If userCommunityId is undefined or '', then the component passing that prop to this component, isn't passing the prop correctly. Lets fix it there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would break in many cases. If userCommunityId is undefined or '', then the component passing that prop to this component, isn't passing the prop correctly. Lets fix it there.

@mzparacha issue is that for me locally is working fine not able to reproduce the bug .even i have latest dump

return (
<UserSkeleton
shouldShowAvatarOnly={shouldShowAvatarOnly}
Expand Down
Loading