Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use blacklist instead of whitelist for events #9817

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Use blacklist instead of whitelist for events #9817

merged 2 commits into from
Nov 5, 2024

Conversation

rbennettcw
Copy link
Contributor

Link to Issue

Closes: #9815

Description of Changes

  • Replaced ALLOWED_EVENTS env with BLACKLISTED_EVENTS

Test Plan

  • CA test
    • Set BLACKLISTED_EVENTS=CommentCreated
    • Create a thread– confirm that the ThreadCreated event is emitted to the outbox
    • Create a comment– confirm that the CommentCreated event is not emitted to the outbox

Deployment Plan

  • AFTER the deployment is finished:
    • Remove env ALLOWED_EVENTS
    • Add env BLACKLISTED_EVENTS=FarcasterCastCreated,FarcasterReplyCastCreated,FarcasterVoteCreated

Other Considerations

N/A

@rbennettcw rbennettcw changed the title Use blacklist instead of whitelist for envs Use blacklist instead of whitelist for events Nov 5, 2024
@rbennettcw rbennettcw merged commit 56a6b97 into master Nov 5, 2024
10 checks passed
@masvelio masvelio added the deployment plan (PRs only) requires manual infrastructure changes on release label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timolegros timolegros timolegros approved these changes

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@kurtisassad kurtisassad Awaiting requested review from kurtisassad

Assignees
No one assigned
Labels
deployment plan (PRs only) requires manual infrastructure changes on release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use blacklist instead of ALLOWED_EVENTS
4 participants
@rbennettcw @Rotorsoft @timolegros @masvelio