Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topics now show correct # threads #9692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

topics now show correct # threads #9692

wants to merge 1 commit into from

Conversation

Israellund
Copy link
Collaborator

Link to Issue

Closes: #9419

Description of Changes

  • user now sees correct number of threads within each topic, not the total number of threads made by the community over its lifetime

"How We Fixed It"

changed the logic to look at threads.length instead of community.lifetime_thread_count

Test Plan

-click around in topics and confirm that the number of discussions changes for each topic
-confirm that that number is correct/count threads in topic

Screen.Recording.2024-10-28.at.8.56.30.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masvelio masvelio masvelio requested changes

@burtonator burtonator Awaiting requested review from burtonator

@mzparacha mzparacha Awaiting requested review from mzparacha

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Thread count in topic should reflect only number of threads in that topic
2 participants
@Israellund @masvelio