-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove chain node from topics + Fix ERC20 voting #9561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbennettcw
changed the title
Remove chain node from topics
Remove chain node from topics + Fix ERC20 voting
Oct 16, 2024
@masvelio looks like the ERC20 UI needs to be updated to remove the chain node selection. |
the dropdown will be there, but will be disabled. I have merge some changes related to this flow so make sure to update your branch with the master |
masvelio
approved these changes
Oct 17, 2024
rbennettcw
added
the
deployment plan
(PRs only) requires manual infrastructure changes on release
label
Oct 18, 2024
Rotorsoft
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9511
Description of Changes
Test Plan
FLAG_FARCASTER_CONTEST=false
(needs to be disabled)FLAG_WEIGHTED_TOPICS=true
0x429ae85883f82203D736e8fc203A455990745ca1
for the addressDeployment Plan
Enable feature flag for weighted voting:
FLAG_WEIGHTED_TOPICS
Other Considerations
N/A