-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove _search
dependency on plaintext
columns
#9170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rotorsoft
reviewed
Sep 10, 2024
Rotorsoft
approved these changes
Sep 10, 2024
Closed
Rotorsoft
approved these changes
Sep 11, 2024
rbennettcw
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9157
Closes: #9171
Description of Changes
plaintext
columns to update the_search
column_search
columns tosearch
because Sequelize doesn't support underscore prefixed column namesgetThreadSearchVector
andgetCommentSearchVector
utility functionsUnfortunately, setting the
search
column cannot be done at the model level (via hooks/triggers) since in the S3 migration the full-text columns will be removed entirely (full body/content would not be available in the hook/trigger).Test Plan
Deployment Plan
Other Considerations