Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _search dependency on plaintext columns #9170

Merged
merged 18 commits into from
Sep 12, 2024
Merged

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Sep 10, 2024

Link to Issue

Closes: #9157
Closes: #9171

Description of Changes

  • Removes triggers which used plaintext columns to update the _search column
  • Renamed _search columns to search because Sequelize doesn't support underscore prefixed column names
  • Created getThreadSearchVector and getCommentSearchVector utility functions

Unfortunately, setting the search column cannot be done at the model level (via hooks/triggers) since in the S3 migration the full-text columns will be removed entirely (full body/content would not be available in the hook/trigger).

Test Plan

  • Create a thread and comment
  • Search for the thread and comment

Deployment Plan

Other Considerations

@timolegros timolegros marked this pull request as ready for review September 10, 2024 11:31
@timolegros timolegros mentioned this pull request Sep 11, 2024
@timolegros timolegros merged commit ec98dfe into master Sep 12, 2024
10 checks passed
@timolegros timolegros deleted the tim/_search-updates branch September 12, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment searching broken Remove _search column dependency on full plain text column
3 participants