Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove substrate_spec field on communities. #8846

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Remove substrate_spec field on communities. #8846

merged 1 commit into from
Aug 14, 2024

Conversation

jnaviask
Copy link
Collaborator

Link to Issue

Closes: #8845

Description of Changes

  • Removes substrate_spec field, originally used for substrate chain connections, now unused.
  • Eliminate some unused substrate dependencies as well.

Test Plan

  • Run migration and update packages. Ensure edgeware community loads + basic actions do not cause issues.

Additional Context

Resolves a TRPC issue from #8779

@jnaviask jnaviask self-assigned this Aug 14, 2024
@jnaviask jnaviask force-pushed the 8845.jake.remove-substrate-spec branch from 21468d7 to 11e7ec1 Compare August 14, 2024 18:47
mzparacha
mzparacha approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@mzparacha mzparacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

Unrelated: I tested Polkadot login just in case (as we removed some packages), and auth seems broken for Polkadot. Created a separate ticket for that here: #8848

timolegros
timolegros approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@timolegros timolegros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I also can't sign in with Polkadot (issue exists in production).

@jnaviask jnaviask merged commit 8bf8d02 into master Aug 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timolegros timolegros timolegros approved these changes

@mzparacha mzparacha mzparacha approved these changes

@Rotorsoft Rotorsoft Awaiting requested review from Rotorsoft

@rbennettcw rbennettcw Awaiting requested review from rbennettcw

Assignees

@jnaviask jnaviask

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate unused substrate_spec field from Communities object
3 participants
@jnaviask @mzparacha @timolegros