Fixed bug where unauthenticated users would get subscription errors in the console.

[burtonator]

Link to Issue

Closes:

• BUG: Trpc error on landing page #8822
• BUG: Non signed users have 401 errors for notifications #8821

Description of Changes

• Moves the subscription toggle and all the associated logic of it to a dedicated class

"How We Fixed It"

Test Plan

• Load a thread when the user is not logged in.
• Make sure there is at least one comment.
• Then check logs and make sure theres no error.
• Make sure toggling of subscriptions works properly when on the thread page (and it has comments)

Deployment Plan

Other Considerations

[masvelio]

The pattern we usually use it to pass enabled flag to the react query. I think in this case it might work as well

export function useCommentSubscriptionsQuery({
  apiEnabled,
}: {
  apiEnabled: boolean;
}) {
  return trpc.subscription.getCommentSubscriptions.useQuery(
    {},
    { enabled: apiEnabled },
  );
}

[masvelio]

original bug is not reproducible for me anymore but I am getting different errors now

[09:26:44.874] ERROR (index.ts): INTERNAL_SERVER_ERROR: [ZodError] subscription.getCommentSubscriptions: [
  {
    "code": "invalid_type",
    "expected": "object",
    "received": "null",
    "path": [
      0,
      "Comment",
      "Thread"
    ],
    "message": "Expected object, received null"
  }
] 
    err: {
      "type": "ZodError",
      "message": "[\n  {\n    \"code\": \"invalid_type\",\n    \"expected\": \"object\",\n    \"received\": \"null\",\n    \"path\": [\n      0,\n      \"Comment\",\n      \"Thread\"\n    ],\n    \"message\": \"Expected object, received null\"\n  }\n]",
      "stack":
          ZodError: [
            {
              "code": "invalid_type",
              "expected": "object",
              "received": "null",
              "path": [
                0,
                "Comment",
                "Thread"
              ],
              "message": "Expected object, received null"
            }
          ]
              at get error [as error] (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/[email protected]/node_modules/zod/lib/index.mjs:587:31)
              at ZodArray.parseAsync (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/[email protected]/node_modules/zod/lib/index.mjs:715:22)
              at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
              at async outputMiddleware (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/index.mjs:308:26)
              at async callRecursive (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/index.mjs:451:32)
              at async callRecursive (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/index.mjs:451:32)
              at async resolve (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/index.mjs:481:24)
              at async inputToProcedureCall (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/resolveHTTPResponse-2fc435bb.mjs:46:22)
              at async Promise.all (index 0)
              at async resolveHTTPResponse (file:///Users/marcin/Desktop/Projects/commonwealth/node_modules/.pnpm/@[email protected]/node_modules/@trpc/server/dist/resolveHTTPResponse-2fc435bb.mjs:182:37)
      "aggregateErrors": [
        {
          "type": "Object",
          "message": "Expected object, received null",
          "stack":
              
          "code": "invalid_type",
          "expected": "object",
          "received": "null",
          "path": [
            0,
            "Comment",
            "Thread"
          ]
        }
      ],
      "issues": [
        {
          "code": "invalid_type",
          "expected": "object",
          "received": "null",
          "path": [
            0,
            "Comment",
            "Thread"
          ],
          "message": "Expected object, received null"
        }
      ],
      "name": "ZodError"
    }

lets fix this in another pr and this is g2g