request the latest clock when signing actions #8780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR is just to merge into #8537 - I've just put it in a separate PR to make it more convenient to discuss with @raykyri
Description of Changes
This PR populates the
clockandparentsfields when the session message (Message<Session>) and action message (Message<Action>) are created. It adds a new endpoint/getCanvasClockwhich returns the current clock and message head ids. This is called from thesignfunction in/packages/commonwealth/client/scripts/controllers/server/sessions.ts.TODO:
Message<Session>object every time a verified action takes place. In theory we should be able to only create one of these, when the user authorises a new session (this happens when the user logs in or when they revalidate a session).Test Plan
Tested by logging in and performing actions