Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First Pass at removing community_id from comments and reactions #8731

Merged
merged 14 commits into from
Aug 9, 2024
Merged

First Pass at removing community_id from comments and reactions #8731

merged 14 commits into from
Aug 9, 2024

Conversation

Rotorsoft
Copy link
Contributor

@Rotorsoft Rotorsoft commented Aug 2, 2024 •
edited
Loading

See ticket

Link to Issue

Closes: #8747

Description of Changes

  • Removes from models
  • Updates queries to use community_id from threads
  • Updates events to include community_id

Test Plan

After running migrate-db to remove community_id columns, make sure you can:

  • View and edit a profile
  • Add new threads and comments
  • React on threads and comments
  • Mark/unmark content as spam
  • Content subscriptions work

@github-actions github-actions bot marked this pull request as draft August 2, 2024 19:45
@Rotorsoft Rotorsoft self-assigned this Aug 2, 2024
@Rotorsoft Rotorsoft marked this pull request as ready for review August 5, 2024 14:50
@rbennettcw
Copy link
Contributor

UI shows error when creating a comment– looks like UI depends on it in some places?
CleanShot 2024-08-07 at 10 23 32@2x

@Rotorsoft
Copy link
Contributor Author

UI shows error when creating a comment– looks like UI depends on it in some places? CleanShot 2024-08-07 at 10 23 32@2x

oops... fixed something that broke this in a couple of places... should work now

kurtisassad
kurtisassad approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@kurtisassad kurtisassad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Clicked around a bunch and nothing seems to break

@Rotorsoft Rotorsoft merged commit 390cc0f into master Aug 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@kurtisassad kurtisassad kurtisassad approved these changes

@timolegros timolegros Awaiting requested review from timolegros

Assignees

@Rotorsoft Rotorsoft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Foreign Key Constraints to community_id from comments and reactions
3 participants
@Rotorsoft @rbennettcw @kurtisassad