-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor profiles in remaining queries referencing Profiles #8480
Refactor profiles in remaining queries referencing Profiles #8480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally works/looks good on first pass but need to resolve conflicts and merge master before I can test more deeply the feeds.
@mzparacha I had to merge other PRs and reconcile the UI model a little bit more to get this working... was planning to do this in the next step, but seems to be impossible in order to meet the full functionality. Please test all the flows again to make sure this is working as expected. Thanks! |
Per the changes done, I tested these user flows
and found this issue
the other things I tested worked for me. cc: @Rotorsoft |
@kurtisassad might be caused by #8041? Specifically https://github.com/hicommonwealth/commonwealth/blob/master/packages/commonwealth/server/controllers/server_threads_methods/update_thread.ts#L110. |
@kurtisassad can you check this? ...seems related to the history PR |
…-routes-utils-profile
packages/commonwealth/test/integration/api/getAddressProfile.spec.ts
Outdated
Show resolved
Hide resolved
75a9b82
to
60d187e
Compare
…ttps://github.com/hicommonwealth/commonwealth into rotorsoft/8472-refactor-server-routes-utils-profile
Link to Issue
Closes: #8472
Description of Changes
Test Plan