Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Rollbar Usage #8249

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Reduce Rollbar Usage #8249

merged 4 commits into from
Jun 26, 2024

Conversation

timolegros
Copy link
Collaborator

Link to Issue

Closes: #8192

Description of Changes

  • Adds input validation to /profile/v2 and /viewComments routes to prevent Invalid Input Syntax Sequelize errors
  • Removes email sending from emitNotifications

Test Plan

  • Start the app
  • View profiles + comments

Deployment Plan

Execute before or after deployment (doesn't matter):

-- update Blast chain node
UPDATE "ChainNodes"
SET private_url = '<insert private chain node URL here>'
WHERE eth_chain_id = 81457;

Other Considerations

@timolegros timolegros added the deployment plan (PRs only) requires manual infrastructure changes on release label Jun 25, 2024
@timolegros timolegros marked this pull request as ready for review June 25, 2024 19:13
@timolegros timolegros mentioned this pull request Jun 26, 2024
Closed
@timolegros timolegros merged commit 74faa4c into master Jun 26, 2024
9 checks passed
@timolegros timolegros deleted the tim/reduce-rollbar-usage branch June 26, 2024 16:10
timolegros added a commit that referenced this pull request Jun 26, 2024
@timolegros
Reduce Rollbar Usage (#8249)
4ee3f16 
* resolve sequelize syntax errors

* remove email notifications

* cleaner solution

* lint

(cherry picked from commit 74faa4c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@kurtisassad kurtisassad kurtisassad approved these changes

@ilijabojanovic ilijabojanovic Awaiting requested review from ilijabojanovic

Assignees
No one assigned
Labels
deployment plan (PRs only) requires manual infrastructure changes on release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce Rollbar Usage
3 participants
@timolegros @kurtisassad @rbennettcw