Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e2e test that broke after pnpm migration. #7980

Merged
merged 2 commits into from
May 30, 2024
Merged

Fix e2e test that broke after pnpm migration. #7980

merged 2 commits into from
May 30, 2024

Conversation

burtonator
Copy link
Collaborator

Fixed an e2e test that broke due to pnpm migration.

Link to Issue

Closes: #7979

Description of Changes

  • Disable the test for now. I tried to fix it but it's difficult to understand our playwright code.

"How We Fixed It"

Test Plan

Deployment Plan

Other Considerations

@burtonator burtonator added the 1 1-2 hour task label May 30, 2024
@github-actions github-actions bot marked this pull request as draft May 30, 2024 15:24
@burtonator burtonator marked this pull request as ready for review May 30, 2024 16:05
@jnaviask jnaviask merged commit 9e45cf0 into master May 30, 2024
8 checks passed
@jnaviask jnaviask deleted the burton/fix-e2e-tests-2 branch May 30, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timolegros timolegros timolegros approved these changes

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@kurtisassad kurtisassad Awaiting requested review from kurtisassad

Assignees
No one assigned
Labels
1 1-2 hour task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E tests broken after pnpm migration.
4 participants
@burtonator @Rotorsoft @timolegros @jnaviask