Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-Onboarding: Auth Type guidance modal #7856

Merged
merged 17 commits into from
May 17, 2024

Conversation

mzparacha
Copy link
Contributor

@mzparacha mzparacha commented May 16, 2024

Link to Issue

Closes: #6642

Description of Changes

Added AuthTypeGuidanceModal that shows up when the user is trying to sign in with an address, that doesn't yet exist on Common.

Screen.Recording.2024-05-16.at.8.58.32.PM.mov

"How We Fixed It"

N/A

Test Plan

  • Enable FLAG_USER_ONBOARDING_ENABLED
  • Logout and select a wallet address (from the wallet extension) that is already connected to common
  • Click on the Sign-in (important) button, and verify you are able to sign in correctly
  • Logout and select a wallet address (from the wallet extension) that is not yet connected to common
  • Click on the Sign-in (important) button, and verify that when you click on the wallet option (ex: Metamask), you get redirected to this modal, this is the AuthTypeGuidanceModal
    image
  • Verify that when you click on Sign in another way, you get redirected back to the sign-in modal. Repeating the sign-in process with the same not-connected-before address should lead you back to this modal.
  • Now when you are back to the AuthTypeGuidanceModal, verify that when you click on Create an account, you get redirected to create account modal. When there, you can create an account like normal.
  • Logout and select another wallet address (from the wallet extension) that is not yet connected to Common
  • Now this time, click on the Create account button and verify that you can create an account like normal. The AuthTypeGuidanceModal won't show up when creating an account with an address that doesn't yet exist on Common.
  • Logout, and click on the Sign in button and try to sign in with any SSO option that you haven't connected to Common before
  • Verify you get redirected to the AuthTypeGuidanceModal modal
  • Verify that when you click on Sign in another way, you get redirected back to the sign-in modal. Repeating the sign-in process with the same not-connected-before address should lead you back to this modal.
  • Now when you are back to the AuthTypeGuidanceModal, verify that when you click on Create an account, you get redirected to create account modal. When there, you can create an account like normal.
  • Mix and match different page states, wallets etc, and verify there is no strange behaviour

Deployment Plan

  1. Enable FLAG_USER_ONBOARDING_ENABLED in unleash
  2. Run DB migrations

Other Considerations

Some SSO options seem to be broken on master branch. This PR only deals with checking if a new SSO is being used.

@mzparacha mzparacha self-assigned this May 16, 2024
@mzparacha mzparacha requested review from masvelio and Israellund May 16, 2024 16:29
@mzparacha mzparacha marked this pull request as ready for review May 16, 2024 16:29
@mzparacha
Copy link
Contributor Author

mzparacha commented May 16, 2024

@mzparacha Getting an error when I'm trying to log out

This is also on master, there is a bug ticket for it here #7861.

Also clearing the cookies to logout would work for testing.

cc: @Israellund

@mzparacha mzparacha merged commit 3c87a97 into master May 17, 2024
8 checks passed
@mzparacha mzparacha deleted the malik.6642.user-guidance-modal branch May 17, 2024 17:27
@mzparacha mzparacha added the deployment plan (PRs only) requires manual infrastructure changes on release label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment plan (PRs only) requires manual infrastructure changes on release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Authentication Flow to Prevent Duplicate Accounts
3 participants