-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User-Onboarding: Auth Type guidance modal #7856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also on Also clearing the cookies to logout would work for testing. cc: @Israellund |
mzparacha
commented
May 16, 2024
masvelio
approved these changes
May 17, 2024
Israellund
approved these changes
May 17, 2024
mzparacha
added
the
deployment plan
(PRs only) requires manual infrastructure changes on release
label
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #6642
Description of Changes
Added
AuthTypeGuidanceModal
that shows up when the user is trying to sign in with an address, that doesn't yet exist on Common.Screen.Recording.2024-05-16.at.8.58.32.PM.mov
"How We Fixed It"
N/A
Test Plan
FLAG_USER_ONBOARDING_ENABLED
Sign-in
(important) button, and verify you are able to sign in correctlySign-in
(important) button, and verify that when you click on the wallet option (ex:Metamask
), you get redirected to this modal, this is theAuthTypeGuidanceModal
Sign in another way
, you get redirected back to the sign-in modal. Repeating the sign-in process with the same not-connected-before address should lead you back to this modal.AuthTypeGuidanceModal
, verify that when you click onCreate an account
, you get redirected to create account modal. When there, you can create an account like normal.Create account
button and verify that you can create an account like normal. TheAuthTypeGuidanceModal
won't show up when creating an account with an address that doesn't yet exist on Common.Sign in
button and try to sign in with any SSO option that you haven't connected to Common beforeAuthTypeGuidanceModal
modalSign in another way
, you get redirected back to the sign-in modal. Repeating the sign-in process with the same not-connected-before address should lead you back to this modal.AuthTypeGuidanceModal
, verify that when you click onCreate an account
, you get redirected to create account modal. When there, you can create an account like normal.Deployment Plan
FLAG_USER_ONBOARDING_ENABLED
in unleashOther Considerations
Some SSO options seem to be broken on
master
branch. This PR only deals with checking if a new SSO is being used.